Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Harness] Fix some typos. #9303

Merged
merged 1 commit into from
Aug 6, 2020
+6 −6
Merged

[Harness] Fix some typos. #9303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/BuildProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
namespace Microsoft.DotNet.XHarness.iOS.Shared.Tasks {
public class BuildProject : BuildTool {
public IResourceManager ResourceManager { get; set; }
public IEnvManager EnviromentManager { get; set; }
public IEnvManager EnvironmentManager { get; set; }
public IEventLogger EventLogger { get; set; }
Func<string> msbuildPath;

Expand All @@ -22,7 +22,7 @@ public BuildProject (Func<string> msbuildPath, IProcessManager processManager, I
this.msbuildPath = msbuildPath ?? throw new ArgumentNullException (nameof (msbuildPath));
ResourceManager = resourceManager ?? throw new ArgumentNullException (nameof (resourceManager));
EventLogger = eventLogger ?? throw new ArgumentNullException (nameof (eventLogger));
EnviromentManager = envManager ?? throw new ArgumentNullException (nameof (envManager));
EnvironmentManager = envManager ?? throw new ArgumentNullException (nameof (envManager));
}

public bool RestoreNugets {
Expand Down Expand Up @@ -58,7 +58,7 @@ async Task<TestExecutingResult> RestoreNugetsAsync (string projectPath, ILog log
args.Add ("-Verbosity");
args.Add ("detailed");
nuget.StartInfo.Arguments = StringUtils.FormatArguments (args);
EnviromentManager.SetEnvironmentVariables (nuget);
EnvironmentManager.SetEnvironmentVariables (nuget);
EventLogger.LogEvent (log, "Restoring nugets for {0} ({1}) on path {2}", TestName, Mode, projectPath);

var timeout = TimeSpan.FromMinutes (15);
Expand Down
2 changes: 1 addition & 1 deletion tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/IResourceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Microsoft.DotNet.XHarness.iOS.Shared.Tasks {

/// <summary>
/// Managed the resorces that can be used by the different tests tasks so that when ran async they do not step
/// on eachother.
/// on each other.
/// </summary>
public interface IResourceManager
{
Expand Down
4 changes: 2 additions & 2 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/MSBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public MSBuild (Func<string> msbuildPath,
xbuild.StartInfo.FileName = msbuildPath ();
xbuild.StartInfo.Arguments = StringUtils.FormatArguments (GetToolArguments (projectPlatform, projectConfiguration, projectFile, buildLog));
xbuild.StartInfo.WorkingDirectory = Path.GetDirectoryName (projectFile);
EnviromentManager.SetEnvironmentVariables (xbuild);
EnvironmentManager.SetEnvironmentVariables (xbuild);
xbuild.StartInfo.EnvironmentVariables ["MSBuildExtensionsPath"] = null;
EventLogger.LogEvent (buildLog, "Building {0} ({1})", TestName, Mode);
if (!dryRun) {
Expand Down Expand Up @@ -99,7 +99,7 @@ async Task CleanProjectAsync (string project_file, string project_platform, stri
args.Add ("/t:Clean");
xbuild.StartInfo.Arguments = StringUtils.FormatArguments (args);
xbuild.StartInfo.WorkingDirectory = Path.GetDirectoryName (project_file);
EnviromentManager.SetEnvironmentVariables (xbuild);
EnvironmentManager.SetEnvironmentVariables (xbuild);
EventLogger.LogEvent (log, "Cleaning {0} ({1}) - {2}", TestName, Mode, project_file);
var timeout = TimeSpan.FromMinutes (1);
await ProcessManager.RunAsync (xbuild, log, timeout);
Expand Down