Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Disable some of linkall's SealerTest in .NET/Release until we can implement them. #9575

Merged
merged 1 commit into from
Sep 7, 2020
Merged

[tests] Disable some of linkall's SealerTest in .NET/Release until we can implement them. #9575

merged 1 commit into from
Sep 7, 2020

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 2, 2020 •
edited
Loading

Fixes these test failures:

Linker.Sealer.SealerTest
[FAIL] Final :   A
    Expected: True
    But was:  False
        at Linker.Sealer.SealerTest.Final()

[FAIL] Sealed :   Sealable
    Expected: True
    But was:  False
        at Linker.Sealer.SealerTest.Sealed()

[FAIL] Virtual :   C
    Expected: False
    But was:  True
        at Linker.Sealer.SealerTest.Virtual()

Ref: #9573

@rolfbjarne
[tests] Disable some of linkall's SealerTest in .NET/Release until we…
727d01d 
… can implement them.

Fixes these test failures:

    Linker.Sealer.SealerTest
    [FAIL] Final :   A
        Expected: True
        But was:  False
            at Linker.Sealer.SealerTest.Final()

    [FAIL] Sealed :   Sealable
        Expected: True
        But was:  False
            at Linker.Sealer.SealerTest.Sealed()

    [FAIL] Virtual :   C
        Expected: False
        But was:  True
            at Linker.Sealer.SealerTest.Virtual()
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Sep 2, 2020
@rolfbjarne rolfbjarne mentioned this pull request Sep 2, 2020
Closed
@monojenkins
Copy link
Collaborator

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit c56b893 into xamarin:main Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rolfbjarne @monojenkins @dalexsoto @spouliot @mandel-macaque @stephen-hawley @whitneyschmidt