Fix field type of PipelineEvent.[]Builds.Runner.RunnerType

It's documented to be of type string, not bool. For more details see #1297
xanzy · Nov 26, 2021 · 7d28f63 · 7d28f63
1 parent cdfb4b0
commit 7d28f63
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/event_parsing_webhook_test.go b/event_parsing_webhook_test.go
@@ -272,6 +272,10 @@ func TestParsePipelineHook(t *testing.T) {
 	if event.Builds[0].ID != 380 {
 		t.Errorf("Builds[0] ID is %v, want %v", event.Builds[0].ID, 380)
 	}
+
+	if event.Builds[0].Runner.RunnerType != "instance_type" {
+		t.Errorf("Builds[0] Runner RunnerType is %v, want %v", event.Builds[0].Runner.RunnerType, "instance_type")
+	}
 }
 
 func TestParsePushHook(t *testing.T) {

diff --git a/event_webhook_types.go b/event_webhook_types.go
@@ -702,7 +702,7 @@ type PipelineEvent struct {
 			Description string   `json:"description"`
 			Active      bool     `json:"active"`
 			IsShared    bool     `json:"is_shared"`
-			RunnerType  bool     `json:"runner_type"`
+			RunnerType  string   `json:"runner_type"`
 			Tags        []string `json:"tags"`
 		} `json:"runner"`
 		ArtifactsFile struct {

diff --git a/testdata/webhooks/pipeline.json b/testdata/webhooks/pipeline.json
@@ -86,7 +86,17 @@
            "email": "user1@example.com",
            "avatar_url": "http://www.gravatar.com/avatar/e32bd13e2add097461cb96824b7a829c?s=80\u0026d=identicon"
         },
-        "runner": null,
+        "runner": {
+            "id": 42,
+            "description": "shared-runners-manager-1.gitlab.com",
+            "runner_type": "instance_type",
+            "active": true,
+            "is_shared": true,
+            "tags": [
+                "docker",
+                "gce"
+            ]
+        },
         "artifacts_file":{
            "filename": null,
            "size": null