Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate missing fields for emails on push integration #1935

Merged
merged 1 commit into from
May 7, 2024

Conversation

heidiberry
Copy link
Contributor

These fields were removed under #1925 but are still present in the API documentation https://docs.gitlab.com/ee/api/integrations.html#emails-on-push.

Adding them back in as updating to the latest tag causes compilation errors in the GitLab Terraform Provider https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/main/internal/provider/sdk/resource_gitlab_integration_emails_on_push.go?ref_type=heads#L177

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I missed these fields being deleted as I normally try to preserve backwards compatibility...

@svanharmelen svanharmelen merged commit aee1e19 into xanzy:main May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants