cluster role: open ports using firewall plugin #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to open 2 ports now (because the clustering port is open at runtime by XAPI, but we have not XAPI here). Can't rely on how the firewall rules file looked like, so just use the same script used by XAPI to open them. Also fix the systemd unit editing rule that added port 8895: the regex must match the line both before and *after* the modification, otherwise if you rerun provisioning you end up with multiple copies of the same line. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
gaborigloi
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to open 2 ports now (because the clustering port is open at
runtime by XAPI, but we have not XAPI here).
Can't rely on how the firewall rules file looked like, so just use the
same script used by XAPI to open them.
Also fix the systemd unit editing rule that added port 8895: the regex
must match the line both before and after the modification, otherwise
if you rerun provisioning you end up with multiple copies of the same
line.
Note: unrelated to this PR, but if you are on Ubuntu 18.04 you will need to
gem install xmlrpc --userto make vagrant-xenserver work again: xapi-project/vagrant-xenserver#54