Skip to content

Commit

Permalink
tracing: increase the default maximum number of spans in a trace
Browse files Browse the repository at this point in the history
Increases the default maximum number of spans inside a trace from `1000`
to `2500`.

Now that we instrumented the internal http calls, with all components
enabled, the number of spans inside `xapi` component for a `vm-start`
operations is slightly  greater than `1000`. This causes spans to be
leaked, they are removed from the ongoing span table but never added in
the finished tabled. Therefore, they are lost unless the limit is
change in `/etc/xapi.conf`.

This should fix the issue until we implement a better abstraction for
the span hashtables.

Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
  • Loading branch information
GabrielBuica committed Aug 5, 2024
1 parent 7fc3a82 commit 9c56331
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ocaml/libs/tracing/tracing.ml
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ module Spans = struct
Hashtbl.length spans
)

let max_spans = Atomic.make 1000
let max_spans = Atomic.make 2500

let set_max_spans x = Atomic.set max_spans x

Expand Down

0 comments on commit 9c56331

Please sign in to comment.