CP-10531: Update vm_guest_metrics to implement PV drivers update #2198
Conversation
|
Hi @simonjbeaumont |
|
FYI. Besides, there's another PR xapi-project/xenopsd#174 for the change of xenopsd. |
|
|
||
| field ~qualifier:DynamicRO ~ty:Bool ~in_oss_since:None | ||
| ~lifecycle:[ | ||
| Deprecated, rel_dundee, "Deprecated in favour of network_paths_optimized and storage_paths_optimized, and redefined in terms of them" |
There was a problem hiding this comment.
Please add Published, rel_rio, "true if the PV drivers appear to be up to date", which is what it implicitly used to have.
There was a problem hiding this comment.
Thanks Rob. I will add it.
|
This generally looks good to me, apart from a few suggestions above. Finally, it would be good to add a little more text to the commit message, explaining what the changes are for (there actually should have been two commit, since there are two distinct changes). I.e. 1) what are these new fields for; 2) how is the old field redefined and why? |
1. Introduce network_paths_optimized and storage_paths_optimized flags to vm_guest_metrics. They are used to represent if VM is using PV network and PV storage frontends. XenCenter could display them respectively. 2. Update the computation of PV_drivers_up_to_date. The value is logical AND of network_paths_optimized and storage_paths_optimized. Also deprecate this flag since the network and storage flags are introduced. Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
|
Hi @robhoes, thanks a lot for your comments and suggestions. Thanks. |
|
@huizh This looks good now, thanks for the update. I'll merge it now. |
CP-10531: Update vm_guest_metrics to implement PV drivers update
|
(Btw: the test build failed, but that seems to be due to infrastructure issues not related to the patch) |
|
Thanks @robhoes. |
Signed-off-by: Hui Zhang hui.zhang@citrix.com