Add 9pfs backend to vbds
#4561
Merged
Add 9pfs backend to vbds
#4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
force-pushed
the
add_9pfs_backend
branch
from
0c91770
to
e063048
Compare
lindig
reviewed
Oct 28, 2021
This allow to use a file path towards a folder instead of a VHD Signed-off-by: BenjiReis <benjamin.reis@vates.fr> Co-authored-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis
force-pushed
the
add_9pfs_backend
branch
from
e063048
to
2d21000
Compare
lindig
approved these changes
Oct 28, 2021
|
Hi! Since it has been validated a long time, can a 2nd person take a look at this to validate/ask for change? :) Thanks |
psafont
reviewed
Jan 26, 2022
| @@ -329,6 +329,8 @@ let params_of_backend backend = | |||
| (path, []) | |||
| | _, _, {uri} :: _, xendisk :: _ -> | |||
| (uri, [("qemu-params", xendisk.Storage_interface.params)]) | |||
| | _, _, _, xendisk :: _ -> | |||
| ("", [("qemu-params", xendisk.Storage_interface.params)]) | |||
There was a problem hiding this comment.
Why is the URI replaced by the empty string?
There was a problem hiding this comment.
No support for spawning nbd I assume, because this is a filesystem, and NOT a block device.
edwintorok
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to use a file path towards a folder instead of a VHD
Signed-off-by: BenjiReis benjamin.reis@vates.fr