Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-364138 log when about to stop varstored and varstore-guard #4645

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

lindig
Copy link
Contributor

@lindig lindig commented Mar 9, 2022

For debugging lost FDs in varstore-guard, log when we call it to stop serving
a domain.

Signed-off-by: Christian Lindig christian.lindig@citrix.com

@edwintorok
Copy link
Contributor

Can you also add some debug messages here?

if Sys.file_exists chroot.root then (
maybe the problem is that they do get called, but the file doesn't exist anymore (because other parts of xenopsd have already cleaned up the chroot)

For debugging lost FDs in varstore-guard, log when whe call it to stop
serving a domain.

Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a good chance to find why the file descriptors aren't freed

@lindig lindig requested a review from robhoes March 10, 2022 11:12
@robhoes robhoes merged commit 3a695bd into xapi-project:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants