Modify xapi.opam for AlpineLinux #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
approved these changes
Apr 11, 2022
|
Thanks! Could you please add sign-offs to the commit messages? There's a requirement for all commits to have it. This can be done by running |
|
@Bobberty could you sign off your commits, please, such that we can merge this? |
|
hwids is unmaintained and will be replaced by hwdata: https://gitlab.alpinelinux.org/alpine/aports/-/issues/14188 |
|
What is the state of this? It looks it could be merged but there is a comment from @psafont that could suggest otherwise. |
|
@Bobberty please rebase and sign-off your commit. We won't merge it otherwise. |
|
I'll push the change here, hwids is not used anymore in alpine and uses hwdata, the same package as the rest of the distributions |
Changed dep for Alpine to correct xxhash package. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an OS package dependency line for AlpineLinux.