Add temporary feature 'Internal_repo_access' to allow update in mix mode #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit d951478, a new function was added to restrict the repository access to pool members only. With this funciton, the pool members need to use pool_secret in access requests to the mirrorred repositories on the pool coordinator for authentication. But in updating, this would cause the pool members can't access the mirrored repositories as at that time the pool coordinator has been updated to check the pool_secret while the pool members have not been udpated to use pool_secret. Per suggestion from Rob Hoes, this commit adds a temporary feature flag to make the pool coordinator be able to distinguish the case in the mixed mode in updating. Signed-off-by: Ming Lu <ming.lu@citrix.com>
robhoes
approved these changes
Apr 19, 2022
lindig
approved these changes
Apr 19, 2022
| enabled" ; | ||
| Http_svr.response_forbidden ~req s | ||
| | _ -> ( | ||
| try |
There was a problem hiding this comment.
This code looks fragile but existed before. We should user higher-level functions to decompose request paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit d951478, a new function was added to restrict the repository
access to pool members only. With this funciton, the pool members need
to use pool_secret in access requests to the mirrorred repositories on
the pool coordinator for authentication.
But in updating, this would cause the pool members can't access the
mirrored repositories as at that time the pool coordinator has been
updated to check the pool_secret while the pool members have not been
udpated to use pool_secret.
Per suggestion from Rob Hoes, this commit adds a temporary feature flag
to make the pool coordinator be able to distinguish the case in the
mixed mode in updating.
Signed-off-by: Ming Lu ming.lu@citrix.com