Don't use --force in gzip decompress #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally gzip stops reading input when it has reached its own end-of input marker even when that is before the end of input. This is overridden by --force for decompression and it is creating a problem for us because suspend images on disk are represented as devices that are larger than the actual content - so --force kept reading beyond the actual input and this in turn was not accepted by the code taking the uncompressed output. Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
|
Did you test that this works for export/import? |
|
I ran BVT/BST - assuming that this would test it |
|
I don't think so. It's better to test it directly to be sure. |
|
I could also introduce a force flag to retain the existing behavior. Will do some manual testing, too. |
|
I've run a |
|
Don't merge yet. There is one failed sub test on the BST which I will re-run |
robhoes
approved these changes
Apr 22, 2022
|
The previously failed test has passed in the re-run. So this should be save to merge. |
psafont
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally gzip stops reading input when it has reached its own end-of
input marker even when that is before the end of input. This is
overridden by --force for decompression and it is creating a problem for
us because suspend images on disk are represented as devices that are
larger than the actual content - so --force kept reading beyond the
actual input and this in turn was not accepted by the code taking the
uncompressed output.
Signed-off-by: Christian Lindig christian.lindig@citrix.com