CP-40669: Restore database should not require ref as the first #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute of row When restore xapi database from xml file, xapi require ref be the first attribute of row, This is not flexible, especially when need to parse and save the xml files. This commit fix this issue by search ref in the attribute list Signed-off-by: Lin Liu <lin.liu@citrix.com>
liulinC
force-pushed
the
private/linl/dev
branch
from
3d4b5bb
to
c730c12
Compare
lindig
approved these changes
Aug 30, 2022
| | (_, "row"), ((_, "ref"), rf) :: rest -> | ||
| (* Remove any other duplicate "ref"s which might have sneaked in there *) | ||
| let rest = List.filter (fun ((_, k), _) -> k <> "ref") rest in | ||
| | (_, "row"), rest -> |
There was a problem hiding this comment.
Altogether, this code is traversing lists multiple times and is inefficient if these lists are long. But that problem is already pre-existing.
The problem at hand is to find the first "ref" entry and to ignore the others. The solution is to split the list based on the key and we expect to find at least one entry. I think the code achieving this could be kept closer together - a sketch is below:
let ref, rest =
match List.partition (fun ((_, k) -> k = "ref")) rest with
| r::_, rest -> r,rest
| [] -> raise ...
psafont
approved these changes
Aug 30, 2022
robhoes
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attribute of row
When restore xapi database from xml file, xapi require ref be
the first attribute of row, This is not flexible, especially when
need to parse and save the xml files.
This commit fix this issue by search ref in the attribute list
Signed-off-by: Lin Liu lin.liu@citrix.com