idl/json_backend: generate data for new-style xapi-releases #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Oct 11, 2022
lindig
approved these changes
Oct 11, 2022
robhoes
reviewed
Oct 12, 2022
Add shorter synonyms for creating paths and writing files Add empty mli since it should not export any functions Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
An ad-hoc solution was used until now. The new code generates compact json that is equivalent to the previous output. I've verified this using jq. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Since xapi 1.249, changes have been attached to xapi versions instead of just a xenserver release. Surface this information to the data that gets used to populate the public documentation webpage Currently it uses a locked API, which might not be maintained in the future, and release dates are not populated which would be good for users to know Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
psafont
force-pushed
the
private/paus/docs
branch
from
6ef5cc5
to
5143cc6
Compare
robhoes
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staarting from xapi release 1.250.0, xapi has relied more and more in its own version, rather than on xenserver releases and "API version".
This has meant that in the public docs there is no information of the API changes that have happened in the last 2 years.
This adds the information about these changes to the metadata that gets published. There are some tweaks that could be made, like adding the date of the release for each of these, or tweak the release datatype to better accomodate this new style, or even move all that information to the metadata generation side instead of being a fundamental part of xapi.
I've taken the liberty to port the json generation here to yojson. I've manually checked using jq that the json produced is equivalent, although the new one has a lot lets whitespace.
Example output using this branch:
