CA-364194: Allow creation of statefiles to time out #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Oct 17, 2022
Because python 2.7 is being used the call to the standard library doesn't support a timeout parameter. In the future this will be useful to protect the script from hanging indefinitely when trying to attach network volumes Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Currently enabling HA can stall because the GFS2 calls when adding the HA statefile might stall indefinitely when there are connection issues Now xapi waits a minute before failing, signalling the user that something has gone awry Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
psafont
force-pushed
the
private/paus/unwedge
branch
from
a2f1e77
to
481611b
Compare
jameshensmancitrix
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently enabling HA can stall because the GFS2 calls when adding the
HA statefile might stall indefinitely when there are connection issues
Now xapi waits a minute before failing, signalling the user that
something has gone awry
Unfortunately using Python 2.7 blocks us from having a timeout in static-vdis, added a comment so it has more chances of getting added when porting to python 3.5+
Xapi helpers now will also print when a script is called without a callback so it's easier to spot similar situations
I've also converted this infrastructure to mtime, but it got big and it's better that this goes in independently