CA-369446: Do not ignore ovs-vsctl failure during VM-start #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Oct 21, 2022
|
I think the commit subject could be shorter (to avoid overflow) and be more descriptive: "exit with error if add_vswitch_port fails" or similar. The body could explain how this is implemented (but it is also quite obvious) once you see the diff |
jameshensmancitrix
force-pushed
the
private/jameshen/xsi-1289
branch
from
45613d3
to
2623756
Compare
Signed-off-by: jameshensmancitrix <james.hensman@citrix.com>
jameshensmancitrix
force-pushed
the
private/jameshen/xsi-1289
branch
from
2623756
to
7605423
Compare
|
Did you manage to test this? |
|
@robhoes What would need to be done to have ovs-vsctl fail on vm start? |
|
Firstly, you need to check that the normal case still works by starting a VM. To test the failure case, you could modify the code to call a fake version of ovs-vsctl that exits with an error. |
robhoes
approved these changes
Oct 24, 2022
psafont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the use of doexec in add_vswitch_port to run using the ON_ERROR_FAIL handler. This will prevent the VM from starting in the case of ovs-vsctl failing.
Signed-off-by: jameshensmancitrix james.hensman@citrix.com