CA-371759: check certificates in xsh #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
approved these changes
Oct 25, 2022
lindig
approved these changes
Oct 25, 2022
ocaml/xsh/xsh.ml
Outdated
| let file = Constants.verify_certificates_path in | ||
| match Sys.file_exists file with | ||
| | false -> | ||
| warn "TLS verification is disabled on this host: %s" file ; |
There was a problem hiding this comment.
This could be misleading: it points to a file that does not exist. So maybe:
"TLS verification is disabled on this host: %s is absent"
There was a problem hiding this comment.
True... I copied this from xapi.ml, so will change it there too.
This program is used to sync blobs across hosts in a pool. It should verify certificates, as for other TLS connections within a pool. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This program is used to sync blobs across hosts in a pool. It should verify certificates, as for other TLS connections within a pool.
Signed-off-by: Rob Hoes rob.hoes@citrix.com