CA-371419: Always log exceptions when responding with 500 Internal Error #4848
Conversation
|
@psafont This happens because of the following lines in /etc/xapi.conf, where logging for the |
By default, logs from the http server are supressed, because it would log far too much. However, it would be valuable to always log the exception that has led to a 500 response, because this error condition is often due to a bug. Logging for these cases is done under a separate name, which is enabled by default. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
| @@ -39,6 +39,8 @@ module D = Debug.Make (struct let name = "http" end) | |||
|
|
|||
| open D | |||
|
|
|||
| module E = Debug.Make (struct let name = "http_internal_errors" end) | |||
There was a problem hiding this comment.
The convention so far is to use the module name name = __MODULE__
There was a problem hiding this comment.
Here we explicitly want a different name.
| let response_internal_error ?req ?extra s = | ||
| let response_internal_error ?req ?extra exc s = | ||
| E.error "Responding with 500 Internal Error due to %s" (Printexc.to_string exc) ; | ||
| E.log_backtrace () ; |
There was a problem hiding this comment.
Can we be sure that we still have the correct backtrace at this point? We had discussion in the past about lost back traces - obviously we will have some backtrace here but is it the correct one? That's why I would like to capture the backtrace first in an exception handler.
There was a problem hiding this comment.
I'm not sure, but this is a catch-all situation. I guess it's better than nothing at this point.
By default, logs from the http server are supressed, because it would log far too much. However, it would be valuable to always log the exception that has led to a 500 response, because this error condition is often due to a bug.
Logging for these cases is done under a separate name, which is enabled by default.
Signed-off-by: Rob Hoes rob.hoes@citrix.com