Eliminate unnecessarily scary log lines #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module ThreadLocalTable uses a Map data structure to keep track of
the name to use for a thread in the logs. A name is normally registered
through a call to `Debug.with_thread_associated`, soon after a thread is
created. However, each time a new context is created through a function
like `Server_helpers.exec_with_new_task`, `Debug.with_thread_associated`
is called as well, which then overwrites the name for the current
thread. When the inner task exits, the old name is not restore, but
simply left blank.
The result is the useful information end up missing from the first part
of log lines. For example. we see this
[error||128 ||xenops]
rather than
[error||128 |xapi events D:4f8a44d7e8d1|xenops]
In the past, there was a Hashtbl instead of a Map here, which does
remember all previous bindings in the table. The Hashtbl was removed in
order to avoid taking the lock in `find`.
This patchs adds a list inside each Map value to model a stack, which
behaves like Hashtbl, but in a pure functional way.
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
|
Draft: still running tests. |
The session.logout was used to interrupt the call to `event.from`, so that is can be called again with a new list of VMs to watch, in case a VM started, stopped etc. The trouble is, that each such re-register event led to SESSION_INVALID being logged, with stack trace, three times. This caused many people looking at the logs unnecessary worries, while in reality the behaviour is completely normal. This replaces the register mechanism by adding the event loop's task into the watch list for `event.from`, and injecting an event on the task to interrupt the call and recompute the VM list. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
robhoes
force-pushed
the
event-logout
branch
from
7078d05
to
65b6012
Compare
lindig
approved these changes
Nov 18, 2022
psafont
approved these changes
Nov 18, 2022
|
BVT and BST test suites passed, except for one thing, which @psafont is checking for relevance to this change. |
|
Test failure looks like something else, so this change is clear. |
|
shoutout to make @rwdrich feel vindicated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.