Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenctrl: drop interface_close #4861

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

edwintorok
Copy link
Contributor

This got removed from Xen 4.18. We only use a global, so switch to using Xenctrl.with_intf.

(We can't use a single global 'xc' value, because that might cause some unit tests to fail since initializing xenctrl outside of a Xen system is not possible, so delaying initialization is still needed).

Signed-off-by: Edwin Török edvin.torok@citrix.com

This got removed from Xen 4.18. We only use a global, so switch to using
Xenctrl.with_intf.

(We can't use a single global 'xc' value, because that might cause some unit
tests to fail since initializing xenctrl outside of a Xen system is not possible,
so delaying initialization is still needed).

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
@edwintorok
Copy link
Contributor Author

/cc @andyhhp

@andyhhp
Copy link
Contributor

andyhhp commented Dec 5, 2022

LGTM

Copy link
Member

@robhoes robhoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks backwards compatible, so can go in now.

@edwintorok edwintorok merged commit c697869 into xapi-project:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants