CP-41279: add migration_compression pool option #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhoes
reviewed
Dec 6, 2022
ocaml/idl/datamodel_pool.ml
Outdated
| @@ -1322,6 +1322,10 @@ let t = | |||
| ~default_value:(Some (VRef null_ref)) "repository_proxy_password" | |||
| "Password for the authentication of the proxy used in syncing with \ | |||
| the enabled repositories" | |||
| ; field ~lifecycle:[] ~ty:Bool ~default_value:(Some (VBool false)) | |||
There was a problem hiding this comment.
You should add ~qualifier:DynamicRO. I'm not sure why the compiler didn't complain about this.
There was a problem hiding this comment.
Thanks, although it should be RW right?
robhoes
reviewed
Dec 6, 2022
ocaml/idl/datamodel_lifecycle.ml
Outdated
| @@ -19,6 +19,8 @@ let prototyped_of_field = function | |||
| Some "22.27.0" | |||
| | "host", "last_software_update" -> | |||
| Some "22.20.0" | |||
| | "pool", "migration_compression" -> | |||
| Some "22.32.0" | |||
There was a problem hiding this comment.
This should have 22.32.0-next if the autogenerator works properly...
There was a problem hiding this comment.
It gave me 22.32.0-next the first time but after some changes only gave me the above
There was a problem hiding this comment.
Odd, but it really must be 22.32.0-next, because this change is not in 22.32.0 (which is the previous release).
|
Looks like you need to update the unit tests. |
lindig
approved these changes
Dec 7, 2022
Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CP-41279
branch
from
30cdb23
to
7128e63
Compare
robhoes
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Woods steven.woods@citrix.com