Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-40950: Make bias against scheduling vms on pool master configurable #4868

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

YanRachel
Copy link
Contributor

By design, the pool master has a bias against scheduling VMs on it, preferring other member hosts.
An option to toggle this bias has been added, which can be used to improve performance, for example when the non-master hosts get overloaded.

@YanRachel YanRachel marked this pull request as ready for review December 12, 2022 10:55
Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in the future we may want to switch the default to false once testing has shown that it is not needed anymore.
I think that the protection we have in Dom0 (with control-slice) against qemu taking away CPU from XAPI should be sufficient these days, but some pool bootstorm tests should give us some data on this.

Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach seems fine, but a couple of red tape changes got outdated

@@ -20,7 +20,7 @@ let prototyped_of_field = function
| "host", "last_software_update" ->
Some "22.20.0"
| "pool", "migration_compression" ->
Some "22.32.0-next"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should be dropped, it's now included in the master branch

ocaml/idl/datamodel_lifecycle.ml Outdated Show resolved Hide resolved
@YanRachel YanRachel force-pushed the private/rachely/CP-40950 branch 2 times, most recently from 671c731 to 1c20384 Compare December 16, 2022 17:37
Signed-off-by: Rachel Yan <Rachel.Yan@citrix.com>
Signed-off-by: Rachel Yan <Rachel.Yan@citrix.com>
@edwintorok
Copy link
Contributor

info.citrite.net is not a URL that is publicly accessible so it is best to avoid posting internal URLs like that in commit messages or PRs.

@edwintorok
Copy link
Contributor

If it is just the 2 screenshots from XenCenter (which is open source) then you can add them directly here, there is now a github feature 'attach files by dragging&dropping,selecting or pasting them' at the bottom of thse comment boxes. Not sure whether it works with images though.

@YanRachel
Copy link
Contributor Author

YanRachel commented Dec 19, 2022

coordinator_bias on (default): image2022-12-19_12-21-16

coordinator_bias off: image2022-12-19_10-21-24

@edwintorok edwintorok merged commit 589012a into xapi-project:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants