Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapi-storage{,-script}: explicitely use python2 instead of python #4875

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

psafont
Copy link
Member

@psafont psafont commented Dec 15, 2022

Other distributions other than Xenserver are used for testing the
installation of packages, and they have removed python as an alias for
python2. Being explicit doesn't break compatibility on Xenserver, and
allows us to keep newer versions of Ubuntu for testing in github.

It also has the benefit of reducing confusion when updating to python3 as the change cannot be done implicitly by switching the python binary.

This is a try to fix the latest error in the nightly CI for the docs: https://github.com/xapi-project/xapi-project.github.io/actions/runs/3700548098/jobs/6275403367

  • Confirm that xapi-storage-script tests aren't using python. (when it's an alias for python3 they fail)
  • Pass ring3 BVT and BST, and storage BST with the changes

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Other distributions other than Xenserver are used for testing the
installation of packages, and they have removed python as an alias for
python2. Being explicit doesn't break compatibility on Xenserver, and
allows us to keep newer versions of Ubuntu for testing in github

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just making the binary explicit

@psafont psafont marked this pull request as ready for review December 16, 2022 09:38
@psafont psafont merged commit c010662 into xapi-project:master Dec 16, 2022
@psafont psafont deleted the private/paus/python2 branch December 16, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants