Switch from Xenctrl.hvm_check_pvdriver to Xenctrl.hvm_param_get #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is technical debt in the hypervisor patchqueue, while the latter is an upstream binding. No functional change. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
|
Might also need to update the mock xenctrl to make the CI happy (it is a copy of xenctrl.mli with the .ml replaced with mock implementations so we can link and run things in the CI, because the upstream xenctrl would just fail if you're not root or you don't have access to /dev/xenctrl, which a CI won't), and typically 'libxen-dev' from distros would be way too old to use in the CI. |
edwintorok
approved these changes
Jan 3, 2023
|
(for merging: xs-opam is actually new enough now to have the new Xen API, so it should be possible to merge this [updated]) |
lindig
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is technical debt in the hypervisor patchqueue, while the latter is an upstream binding.
No functional change.
Signed-off-by: Andrew Cooper andrew.cooper3@citrix.com