CP-41366: Rename Citrix Hypervisor to XenServer #4885
Conversation
|
Don't worry about ocaml/sdk-gen, it will be handled by the UI team. |
There was a problem hiding this comment.
I think we're not supposed to have branding in the code, but load the branding from /etc/xensource-inventory instead. Obviously that doesn't work for documentation,
and you'd first need to load the inventory to know the brand, and if that is missing...
But if that is missing something has gone really bad with the install, perhaps we could have a more neutral message: "unable to load XAPI inventory configuration?"
scripts/xe-xentrace
Outdated
| @@ -31,7 +31,7 @@ done | |||
| SIZE=$((${SIZE_GB} * 1024 * 1024 * 1024)) | |||
|
|
|||
| if [ ! -e @INVENTORY@ ]; then | |||
| echo Must run on a Citrix Hypervisor host. | |||
| echo Must run on a XenServer host. | |||
There was a problem hiding this comment.
Could this be more generic, e.g. 'Must run on a XAPI host', then we don't need to update this every time we change the branding (the inventory contains the branding...)
There was a problem hiding this comment.
OK, I've updated the scripts/xe-* files. I think the rest are docs and examples so not appropriate to get branding from /etc/xensource-inventory for them.
There was a problem hiding this comment.
Did you push the commit, I don't see it on github
There was a problem hiding this comment.
Oops... I have now pushed it to the correct place.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
|
This is changing user-visible documentation but not copyright - which is the right approach. |
rosslagerwall
force-pushed
the
private/rossla/CP-41366
branch
from
9f1738b
to
51dffb2
Compare
Signed-off-by: Ross Lagerwall ross.lagerwall@citrix.com
This doesn't anything regarding the SDK.