XSI-1457: Limit number of sectors to coalesce #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
bar
branch
3 times, most recently
from
7d8373b
to
838e7e8
Compare
lindig
approved these changes
Oct 26, 2023
psafont
reviewed
Oct 26, 2023
We limit the number of sectors to coalesce when generating a list of elements to be copied. The limit is currently set to 4 MiB. This allows the progress bar to be displayed at a finer granularity rather than going from 0 to 100 in one go due to one big sector being generated. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
psafont
approved these changes
Oct 27, 2023
robhoes
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the progress bar display more interactive, we limit the amount of consecutive sectors to coalesce when generating a list to copy.