CA-384936 attach static VDIs for redo-log #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2023 16:03
We have a case where we don't know why the redo log is not found on boot. We need this log entry to understand if any VDIs are found. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
The redo-log without HA is missing to attach the static VDIs that actually contain the redo log. Call the same code that we are using in the HA case. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
psafont
approved these changes
Nov 8, 2023
| @@ -531,6 +531,7 @@ let start_redo_log () = | |||
| && not (bool_of_string (Localdb.get Constants.ha_armed)) | |||
| then ( | |||
| debug "Redo log was enabled when shutting down, so restarting it" ; | |||
| Static_vdis.reattempt_on_boot_attach () ; | |||
There was a problem hiding this comment.
Is there a way to share init code in both cases instead of adding more actions here and comparing with the HA case?
There was a problem hiding this comment.
This is pretty minimal; otherwise we would need to refactor all this redo log code. I suspect this fix is missing in the DR code as well.
|
The test that found this issue passes with this change. |
edwintorok
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redo-log without HA is missing to attach the static VDIs that
actually contain the redo log. Call the same code that we are using in
the HA case.