CA-386582: Always create exporting thread for observers #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
reviewed
Dec 12, 2023
| Xapi_stdext_threads.Threadext.Mutex.execute lock (fun () -> | ||
| match !exporter_created with | ||
| | None -> | ||
| let tid = create_exporter () in |
There was a problem hiding this comment.
We are creating an exporter - but assign to a tid - which is a thread ID? Naming could be more congruent such that the function creating a value is related to the variable holding that value. We have here exporter_created, create_exporter and tid which refer to related values but you can't tell this from their names.
There was a problem hiding this comment.
tid is the thread id of the exporter, it is a temporary variable holding the value of that id. It's just easier to have this temporary variable rather than storing the value in exporter directly, which can be a bit awkward since it is a option value, and what we want to return is the actual value without the option
Vincent-lau
force-pushed
the
private/shul2/observer-init
branch
2 times, most recently
from
7209431
to
053b9b2
Compare
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Previously the exporting thread for observer is only created when there is an observer stored in the database associated with a component. This is not the original intent of how observers should be used. We want to create the exporting thread regardless of whether we have any observers so that when observers are created later on, their spans can be exported, since creating an observer will not check for the existence of an exporting thread. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
This allows the observer to be created _after_ clusterd has been started. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/observer-init
branch
from
0ac4492
to
f36ae95
Compare
lindig
approved these changes
Dec 14, 2023
psafont
approved these changes
Dec 15, 2023
robhoes
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create observer exporting thread regardless of whether we have observers in database.