OIL: introduce internal_error(fmt) for error reporting #5334
Conversation
| @@ -2731,10 +2727,9 @@ and perform_exn ?subtask ?result (op : operation) (t : Xenops_task.task_handle) | |||
| the destination host. even though the destination host | |||
| failed to respond successfully to our handshake, the VM | |||
| should still be running correctly *) | |||
| error | |||
| internal_error | |||
There was a problem hiding this comment.
This changes the string of the exception compared to the old code. But it just adds more info to the message, which should be fine.
| in | ||
| error "%s: %s" __FUNCTION__ err_msg ; | ||
| raise (Xenopsd_error (Internal_error err_msg)) | ||
| internal_error "More than one domain with uuid %s: (%s)" uuid' domid_list | ||
| | exception Failure r -> | ||
| raise (Xenopsd_error (Internal_error r)) |
| @@ -30,6 +30,14 @@ let finally = Xapi_stdext_pervasives.Pervasiveext.finally | |||
|
|
|||
| let with_lock = Xapi_stdext_threads.Threadext.Mutex.execute | |||
|
|
|||
| let internal_error fmt = | |||
There was a problem hiding this comment.
You have 2 copies of this, I assume because the 'error' function is different (it includes the module name).
There was a problem hiding this comment.
Indeed; otherwise you need to make sure it's logged under the correct name.
|
In my new code I log the error just to be very close to the origin of that error and because I don't want to rely on top-level code that might or might not log the error. But you are right that we could decide not to log at this point. |
lindig
force-pushed
the
private/christianlin/oil
branch
from
198a456
to
fe3629b
Compare
Simplify the logging and reporting of internal errors in xenopsd. Rather than constructing a complex exception use a function that accepts a printf-style string for convenience. It logs the error and raises the exception. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
lindig
force-pushed
the
private/christianlin/oil
branch
from
fe3629b
to
63f1a42
Compare
|
I was too eager in one case and changed the exception - fixed that back to the original code: |
Simplify the logging and reporting of internal errors in xenopsd. Rather than constructing a complex exception use a function that accepts a printf-style string for convenience. It logs the error and raises the exception.