Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-47389 Porting mail-alarm to python3 #5400

Merged
merged 6 commits into from
Feb 26, 2024
Merged

CP-47389 Porting mail-alarm to python3 #5400

merged 6 commits into from
Feb 26, 2024
+66 −44

Commits on Feb 20, 2024

  1. format with black and isort 

    Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d5a73b2 View commit details
    Browse the repository at this point in the history

  2. Address the error raised by pytype 

    Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    dd6d4f4 View commit details
    Browse the repository at this point in the history

  3. Fix str.encode issue in python3 

    Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    82da5a5 View commit details
    Browse the repository at this point in the history

  4. fix issue: json.load in python3 doesn't have 'encoding' paramteter 

    Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    adac070 View commit details
    Browse the repository at this point in the history

  5. add a conditiall branch for ensuring pass in python2 ut 

    Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f42f23f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Error: scripts/mail-alarm was changed, remove it from expected_to_fai… 

    …l in pyproject.toml and make sure it passes pytype checks

Signed-off-by: Fei Su <fei.su@cloud.com>
    @acefei
    acefei committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    089ed2a View commit details
    Browse the repository at this point in the history