sync feature/py3 branch with the master branch #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is a first shot on configuring Codecov for the Xen-API repo.
- It might need further tweaks, but it is a first step towards
what I think we want Codecov to do.
Steps taken:
- Only add the Codecov comment to the PR when coverage changes
- Remove not needed noise from the Codecov PR comment
- Give examples on how to configure how much code must be covered
for Codecov to pass the coverage check of a PR
- Disable adding coverage annotations to the code in the GitHub
Code Review for now:
- The coverage can be visited using the Codecov link at all times.
https://app.codecov.io/gh/xapi-project/xen-api/pulls
- The annotations consume a lot of space in the PR code review,
and can make it hard to review files that are not covered yet.
- The annotations can be hidden in GitHub PR code review by
pressing the "a" key or by deselecting the "Show comments"
checkbox, but they are shown by default.
- The Codecov Chrome and Firefox extension is a much nicer
way to indicate coverage:
Link: https://github.com/codecov/codecov-browser-extension
- How to enable: You need to log in to Codecov "using Github".
For Firefox, enable the needed permissions:
codecov/codecov-browser-extension#50
- Show the Codecov status without waiting for other status to pass
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
…config-pr-comment-and-checks
Signed-off-by: Steven Woods <steven.woods@citrix.com>
…just-test-coverage-gate
psafont
approved these changes
Feb 26, 2024
Vincent-lau
approved these changes
Feb 26, 2024
pytype_reporter extracted 48 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.