CA-389241: import-update-key compat with xs8 and xs9

[liulinC]

XS9 3943842

[08:13:19 04/03] SSH root@10.63.81.27 /opt/xensource/debug/import-update-key /opt/xenrt/keys/RPM-GPG-KEY-XS-Eng-Test.pub
gpg: key 7610CBCE078E581F: public key "XS Eng test key <XenServerEngineering@citrite.net>" imported
gpg: Total number processed: 1
gpg:               imported: 1

gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   2  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 2u
pub  rsa2048/7610CBCE078E581F
     created: 2024-01-08  expires: 2024-07-06  usage: SCEA
     trust: unknown       validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

pub  rsa2048/7610CBCE078E581F
     created: 2024-01-08  expires: 2024-07-06  usage: SCEA
     trust: unknown       validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

Please decide how far you trust this user to correctly verify other users' keys
(by looking at passports, checking fingerprints from different sources, etc.)

  1 = I don't know or won't say
  2 = I do NOT trust
  3 = I trust marginally
  4 = I trust fully
  5 = I trust ultimately
  m = back to the main menu


pub  rsa2048/7610CBCE078E581F
     created: 2024-01-08  expires: 2024-07-06  usage: SCEA
     trust: ultimate      validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>
Please note that the shown key validity is not necessarily correct
unless you restart the program.


pub  rsa2048/7610CBCE078E581F
     created: 2024-01-08  expires: 2024-07-06  usage: SCEA
     trust: ultimate      validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

XS8 25618140

[07:59:24 04/03] SSH root@10.62.65.39 /opt/xensource/debug/import-update-key /opt/xenrt/keys/RPM-GPG-KEY-XS-Eng-Test.pub
gpg: key 078E581F: public key "XS Eng test key <XenServerEngineering@citrite.net>" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

gpg: checking the trustdb
gpg: 3 marginal(s) needed, 1 complete(s) needed, PGP trust model
gpg: depth: 0  valid:   2  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 2u
pub  2048R/078E581F  created: 2024-01-08  expires: 2024-07-06  usage: SCEA
                     trust: unknown       validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

pub  2048R/078E581F  created: 2024-01-08  expires: 2024-07-06  usage: SCEA
                     trust: unknown       validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

Please decide how far you trust this user to correctly verify other users' keys
(by looking at passports, checking fingerprints from different sources, etc.)

  1 = I don't know or won't say
  2 = I do NOT trust
  3 = I trust marginally
  4 = I trust fully
  5 = I trust ultimately
  m = back to the main menu


pub  2048R/078E581F  created: 2024-01-08  expires: 2024-07-06  usage: SCEA
                     trust: ultimate      validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>
Please note that the shown key validity is not necessarily correct
unless you restart the program.


pub  2048R/078E581F  created: 2024-01-08  expires: 2024-07-06  usage: SCEA
                     trust: ultimate      validity: unknown
[ unknown] (1). XS Eng test key <XenServerEngineering@citrite.net>

[edwintorok]

No more version detection, this looks good now.
Please run some automated tests on both XS8 and XS9 to check it works on both.

[liulinC]

New XenRT:

• XS8: 3947678
• XS9: 3947677, Import key succeed. Failed with known issue which will be fixed in another ticket.

[lindig]

This needs to be /bin/bash because the script it using bash features and would not work in a Posix shell.

[liulinC]

I merged the PR, will fix it up later.
Could you clarify which feature causing that issue? My testing of sh -x looks good.

[lindig]

Sorry, I was wrong. I assumed ${#keyhash} (for string length) requires bash but it is in Posix.

[github-actions]

pytype_reporter extracted 50 problem reports from pytype output

.

You can check the results of the job here