CA-389506: fix platform:nested_virt typo #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested virt is not a supported feature yet, but when moving the setting from Xen to toolstack as part of the Xen-4.17 update I typoed the name of the setting. It was platform/nested-virt in xenguest.patch before Fixes: 664de76 ("Xen-4.15+: CDF_NESTED_VIRT") Signed-off-by: Edwin Török <edwin.torok@cloud.com>
|
Draft until this is tested. |
psafont
approved these changes
Mar 5, 2024
|
Might take a while to test, DNS is broken currently, so can't autheneticate to Koji, so can't build/test anything at the moment. |
lindig
approved these changes
Mar 5, 2024
|
I think we need to do something more, as this doesn't actually work yet, the required feature bits are now missing from CPUID, and since the toolstack is now in charge of the policy more we might have some additional work to do here. |
pytype_reporter extracted 47 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested virt is not a supported feature yet, but when moving the setting from Xen to toolstack as part of the Xen-4.17 update I typoed the name of the setting.
It was platform/nested-virt in xenguest.patch before
Fixes: 664de76 ("Xen-4.15+: CDF_NESTED_VIRT")
I'll also need to find another test to use that checks whether the feature works, the previous test that I used tested the feature by booting a guest, and checking that it has booted, without checking whether nested virt actually worked inside.