Bring feature/perf up-to-date with master #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
Different network card (like virtual ones or USB ones) do not have a vendor:product causing networkd daemon to report a lot of errors like Error in read one line of file: /sys/class/net/eth0/device/device, exception Unix.Unix_error(Unix.ENOENT, "open", "/sys/class/net/eth0/device/device") Raised by primitive operation at Xapi_stdext_unix__Unixext.with_file in file "lib/xapi-stdext-unix/unixext.ml", line 68, characters 11-40 Called from Xapi_stdext_unix__Unixext.buffer_of_file in file "lib/xapi-stdext-unix/unixext.ml" (inlined), line 155, characters 31-83 Called from Xapi_stdext_unix__Unixext.string_of_file in file "lib/xapi-stdext-unix/unixext.ml", line 157, characters 47-73 Called from Network_utils.Sysfs.read_one_line in file "ocaml/networkd/lib/network_utils.ml", line 156, characters 6-33 Do not report these missing file as errors. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
- This is a first shot on configuring Codecov for the Xen-API repo.
- It might need further tweaks, but it is a first step towards
what I think we want Codecov to do.
Steps taken:
- Only add the Codecov comment to the PR when coverage changes
- Remove not needed noise from the Codecov PR comment
- Give examples on how to configure how much code must be covered
for Codecov to pass the coverage check of a PR
- Disable adding coverage annotations to the code in the GitHub
Code Review for now:
- The coverage can be visited using the Codecov link at all times.
https://app.codecov.io/gh/xapi-project/xen-api/pulls
- The annotations consume a lot of space in the PR code review,
and can make it hard to review files that are not covered yet.
- The annotations can be hidden in GitHub PR code review by
pressing the "a" key or by deselecting the "Show comments"
checkbox, but they are shown by default.
- The Codecov Chrome and Firefox extension is a much nicer
way to indicate coverage:
Link: https://github.com/codecov/codecov-browser-extension
- How to enable: You need to log in to Codecov "using Github".
For Firefox, enable the needed permissions:
codecov/codecov-browser-extension#50
- Show the Codecov status without waiting for other status to pass
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
the data field is not part of meta. see the XML generator at ocaml/libs/xapi-rrd/lib/rrd_updates.ml line 124 The issue was introduced when serialization was changed to use yojson: xapi-project/xcp-rrd@048b0e3 Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
… in C# SDK Also: - Rename `README.dist` and `README-NuGet.dist` to `README.md` and `README-NuGet.md` - Change content of aforementioned READMEs to use markdown - Remove mentions of patched Json.NET library - Update copyright notice year - Do not add `.txt` extension to `LICENSE` file Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Hyphens are converted when using `ResGen.exe` but they shouldn't be used to keep a consistent style Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Enables building without the use of `ResGen.exe` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Discussed here: xapi-project#5462 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
…config-pr-comment-and-checks
- New pif helper: `get_non_link_ipv6` to get the 1st non link IPv6 of a PIF - Use the helper in `migrate_receive` and `get_primary_address` used in host evacuation to have a valid IPv6 of the destination host Co-authored-by: Pau Ruiz Safont <psafont@users.noreply.github.com> Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Signed-off-by: Steven Woods <steven.woods@citrix.com>
…just-test-coverage-gate
Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
Also: - Update copyright notices - Update `README` files to use markdown - Add `.gitignore` file - Drop extension from `LICENSE.txt` - Add `.sln` file since it's needed for NuGet usage in VS22 - Add .NET 8.0 to list of target frameworks for the SDK project - Ensure all DLLs are placed in `bin/` when running `dotnet build`. Without `CopyLocalLockFileAssemblies = true` this is not the case for .NET builds. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Makes use of new composite action that sets up a XenAPI environment in a Ubuntu node. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…providing user friendlier messages on the client side). Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
This can then be used by observer.py, whereas the value 'bugtool' was useless Signed-off-by: Steven Woods <steven.woods@citrix.com>
This enables the sampled flag (https://www.w3.org/TR/trace-context/#sampled-flag). This indicates that we may have recorded trace data. In the future if we use sampling, this flag can be set with more granularity. Signed-off-by: Steven Woods <steven.woods@citrix.com>
This is necessary for the python observers to set their local endpoint value. It also allows filtering traces by component Signed-off-by: Steven Woods <steven.woods@citrix.com>
The default_attributes are not added to the DB and so these are missing in the observer.conf. Dom0ObserverConfig currently lacks a single source of truth outside of the DB (and default_attributes is not given to the DB) and so attributes outside of the DB are lost whenever a different setter function is used. This should be reworked in future so that observer.conf is read from/updated instead of regenerated each time. Signed-off-by: Steven Woods <steven.woods@citrix.com>
This reverts commit 6668d5f. Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
…389206 Revert "CP-45572: Print update guidance in xe host-apply-updates"
…is empty" This reverts commit 397d47a. Signed-off-by: Ming Lu <ming.lu@cloud.com>
This reverts commit 533a000. Signed-off-by: Ming Lu <ming.lu@cloud.com>
This reverts commit 8ca4b43. Signed-off-by: Ming Lu <ming.lu@cloud.com>
This reverts commit a53e54d. Signed-off-by: Ming Lu <ming.lu@cloud.com>
…6-warnings-update-to-checkout@v4
…6-warnings-update-setup-dotnet@v4
…6-warnings-update-to-artifact@v4
…6-warnings-update-to-dotenv@v1.1 GitHub Action to read .env files: Update to falti/dotenv-action@v1 (fixes Node 16 warnings)
shellscripts: fix the worse complaints from shellcheck
The custom logrotation setup for xapi sometimes conflicted with the normal one. Remove the former. Install the xapi logrotate configuration has been moved to be managed as part of the normal logrotation, with the global settings removed. Duplicate settings in the configuration have been removed. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Also update URL in `pom.xml` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
The bug is in parsing the output of 'xen-livepatch list'. The following output can't be parsed correctly: lp_4.17.3-3.11.gf717213.xs8-4.17.3-3.12.xs8| CHECKED The regex pattern doesn't exclude the '|' after 'xs8'. As a result, the vertical line '|' is parsed as part of '3.12.xs8|'. The correct one should be '3.12.xs8'. Signed-off-by: Ming Lu <ming.lu@cloud.com>
…389840 CA-389840: Bug in parsing output of 'xen-livepatch list'
…tate domains Signed-off-by: Lunfan Zhang <Lunfan.Zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
…CP-48430 CP-48430 Update the running_domains metrics to include the blocked state domains
[OIL] Moved some more generation code to templates.
Not used. It was never implemented. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
Not used. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
Before these changes, the `SaveCertificates` method relied on machines having a `SpecialFolder.MyDocuments` folder. This is true in Windows and GUI versions of some Linux distros, but it's an assumption that caused the save method to fail if the folder didn't exist. With this commit, we're storing and reading from the path where `$PROFILE` is stored, which is platform agnostic from the point of view of the SDK. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/perf #5523 +/- ##
==============================================
+ Coverage 49.0% 51.8% +2.7%
==============================================
Files 18 19 +1
Lines 2319 2586 +267
==============================================
+ Hits 1138 1341 +203
- Misses 1181 1245 +64
Flags with carried forward coverage won't be shown. Click here to find out more. |
robhoes
approved these changes
Mar 20, 2024
psafont
approved these changes
Mar 21, 2024
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 'git merge upstream/master', fixing the one conflict in the Makefile.
git wouldn't let me push this directly to 'feature/perf' without a PR though.