Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-393421: Special VMs cannot be added to VM groups #5653

Merged
merged 1 commit into from
May 30, 2024
Merged

CA-393421: Special VMs cannot be added to VM groups #5653

merged 1 commit into from
May 30, 2024

Conversation

BengangY
Copy link
Contributor

Control domains, templates, and snapshots cannot be added to VM groups.

@BengangY BengangY marked this pull request as ready for review May 28, 2024 14:40
@gangj
Copy link
Contributor

gangj commented May 29, 2024 •
edited
Loading

Please add this error to set_groups prototype in idl, like this one: https://github.com/xapi-project/xen-api/blob/master/ocaml/idl/datamodel_vm.ml#L263

@BengangY
CA-393421: Special VMs cannot be added to VM groups
7fcef06 
Control domains, templates, and snapshots cannot be added to
VM groups.

Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
@BengangY BengangY force-pushed the private/bengangy/CA-393421 branch from 60b014b to 7fcef06 Compare May 29, 2024 10:16
@robhoes robhoes merged commit 6640b38 into xapi-project:feature/vm-anti-affinity May 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangj gangj gangj approved these changes

@minglumlu minglumlu minglumlu approved these changes

@robhoes robhoes robhoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BengangY @gangj @robhoes @minglumlu