CA-394109: Reduce number of alerts #5696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
2 times, most recently
from
c0fe06a
to
2faefbe
Compare
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
from
2faefbe
to
74851ba
Compare
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
3 times, most recently
from
6f55aea
to
0dbfad9
Compare
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
from
1384b5e
to
4685175
Compare
lindig
approved these changes
Jun 25, 2024
| (fun h -> not (List.mem h quorum_hosts)) | ||
| all_cluster_hosts | ||
| let dead_hosts = | ||
| List.filter (fun h -> not (List.mem h live_hosts)) all_cluster_hosts |
There was a problem hiding this comment.
Should we use sets here? This is O(n^2).
There was a problem hiding this comment.
the maximum number of hosts we support is 16, so maximum complexity is 256, should be fine, what do you think?
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
from
4685175
to
22ffd5e
Compare
|
Checking format failed. If you use VSCode, you can configure setting.json to auto-format when saving the code like this: |
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
2 times, most recently
from
9bf46ef
to
9143797
Compare
psafont
reviewed
Jul 8, 2024
psafont
approved these changes
Jul 8, 2024
|
going to run a quick xrt test to make sure these changes are good, since it has been in the review fow a while |
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
from
9143797
to
c66e731
Compare
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Use the Atomic module to track whether a watcher has been created. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
|
Added a feature flag, and tests look ok, merge this one now. |
Vincent-lau
force-pushed
the
private/shul2/less-alert
branch
from
c66e731
to
cca43a4
Compare
This allows one to force sync the state of xapi db with the cluster stack, useful for cluster API methods change the state of the cluster. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Previously there were two ways an alert for a cluster host join/leave can be raised: 1. through the cluster change watcher; 2. through the api call. These two can generate duplicate alerts as an API call can cause the cluster change watcher to notice the change as well. The idea of the fix here is still to let API and watcher raise alerts separately, but now add synchronous API calls to allow API call (cluster-host-join, etc) to call the cluster change update code at the right time so that the cluster change watcher won't see the change again, hence not generating duplicate alerts. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relatively large change, best reviewed by commit