epoll: introduce test-open and improve logging on failure in xapi startup and database. code #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
force-pushed
the
private/edvint/epoll3.0-pr
branch
from
5601c05
to
9061698
Compare
lindig
approved these changes
Jun 19, 2024
psafont
approved these changes
Jun 19, 2024
Previously the exception would've been completely ignored, so all we've seen in the logs was the successful connection attempt, and then closing the connection after sending 0 bytes. We were not seeing that Thread.wait_timed_read raised an exception due to a file descriptor having a value >1024. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/epoll3.0-pr
branch
from
9061698
to
bc509ec
Compare
We'll check statically that we are not using Unix.select, but it is good to have a runtime check too, in case some library (C or OCaml) indirectly uses it. Default is 0 but can be set to 1024 to test for the absence of Unix.select. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/epoll3.0-pr
branch
from
bc509ec
to
3500e5a
Compare
…rtup failures If 'server_init' raised an exception previously we wouldn't be able to log the full stacktrace. Enable backtraces earlier to ensure that we can. We need to use Debug.with_thread_associated instead of just Backtrace.with_backtraces, because if the thread is not registered, then xapi-backtrace won't print the backtrace even if it has one. A startup failure now looks like this in the logs: ``` Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] Xapi.watchdog failed with exception Unix.Unix_error(Unix.EMFILE, "dup", "") Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] Raised Unix.Unix_error(Unix.EMFILE, "dup", "") Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 1/7 xapi Raised at file ocaml/libs/xapi-stdext/lib/xapi-stdext-unix/unixext.ml, line 873 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 2/7 xapi Called from file ocaml/xapi/xapi.ml, line 936 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 3/7 xapi Called from file ocaml/xapi/xapi.ml, line 946 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 4/7 xapi Called from file ocaml/xapi/xapi.ml, line 1535 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 5/7 xapi Called from file ocaml/xapi/xapi.ml, line 1541 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 6/7 xapi Called from file ocaml/xapi/xapi.ml, line 1548 Jun 19 04:58:41 lcy2-dt72 xapi: [error||0 ||backtrace] 7/7 xapi Called from file ocaml/libs/log/debug.ml, line 250 ``` Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are the only changes I have before we'd attempt a merge of feature/perf (with more epoll related content that I'll move to feature/epoll instead).