CP-49922: mv scripts/probe-device-for-file to python3/libexec
#5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jun 21, 2024
ashwin9390
force-pushed
the
private/ashwin/CP-49922
branch
from
2b2a318
to
4e461cd
Compare
bernhardkaindl
suggested changes
Jun 24, 2024
ashwin9390
force-pushed
the
private/ashwin/CP-49922
branch
from
4e461cd
to
1a625ec
Compare
bernhardkaindl
force-pushed
the
private/ashwin/CP-49922
branch
2 times, most recently
from
1200163
to
e73bb67
Compare
Also fix multiple-import on same line and indentation/spacing. Signed-off-by: Ashwinh <ashwin.h@cloud.com>
bernhardkaindl
force-pushed
the
private/ashwin/CP-49922
branch
from
e73bb67
to
e95a92b
Compare
bernhardkaindl
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Looks better now.
I cleaned up the very verbose commit message (that detail isn't needed there).
- I also removed the obsolete line
Fixed pyright error: "device" is unbound and error: "file" is unbound (reportUnboundVariable) issue
(was caused by wrong indentation that broke the script).- That means:
pyrightalready found a real bug that would have been introduced by wrong indentation (when making changes in this PR) otherwise. - I added a line to the commit message mentioning the not already described changes to fix the multiple-import warning and spacing/indentation:
Also fix multiple-import on same line and indentation/spacing.
- That means:
bernhardkaindl
changed the title
scripts/probe-device-for-file to python3/libexec
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
psafont
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.
Sub task CP-49922:
Signed-off-by: Ashwinh ashwin.h@cloud.com