Instrument task related functionality

[GabrielBuica]

Instruments task related functions.

Some other improvements:

• Context.with_tracing now records the error inside the span;
• Context.complete_tracing is now called with finally.

[contificate]

Pedantically, I'd prefer we worked towards avoiding infix usage of @@ as it's an eyesore.

We can use let (let*) = (@@) and write let* __context = e in e'. Would be interested to hear what others think (even if the topic of syntax is as bikeshedding as it gets).

[lindig]

I don't have strong opinions on @@; I think the usage here was appropriate to wrap existing code. With the suggestion, we might run into the problem that let* is used for other purposes but we would use let@, I assume.

[GabrielBuica]

I quite like the visual of @@ for with_tracing functions as they are mostly called at the start of the functions and you know that the entire scope will be inside at span. The downside is that it's not easy to follow that the argument is being changed: span/__context/dbg/etc.

As far as I am aware let* is used as a bind operator and from a quick search through the codebase let@ is defined as let ( let@ ) f x = f x . So, if we agree that a custom let operator is more readable I'd use the later.

[Vincent-lau]

Looks good to me, but might need another eye from some one who's familiar with tracing as it is a relatively large change

[edwintorok]

Looks good, although we should test that exceptions from the tracing module don't cause failures.

[edwintorok]

Looks good, can you squash the fixups into their respective commits (a git rebase should do that).