Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-49912: Moved scripts/mail-alarm to python3/libexec directory #5757

Merged

Conversation

ashwin9390
Copy link
Contributor

Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.

Sub task CP-49912:

  • Moved scripts/mail-alarm to python3/libexec directory
  • Modified python3/Makefile to include these changes

Signed-off-by: Ashwinh ashwin.h@cloud.com

@lindig
Copy link
Contributor

lindig commented Jul 1, 2024

Is this just about the new location or also about the mail-alarm script as well?

@ashwin9390
Copy link
Contributor Author

ashwin9390 commented Jul 1, 2024

Is this just about the new location or also about the mail-alarm script as well?

This PR is about moving scripts to python3 directory and modifying Makefile in python directory ,no changes in the script as it was ported to python3.

Copy link
Member

@psafont psafont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the file from scripts/

- Modified python3/Makefile to include these changes

Signed-off-by: Ashwinh <ashwin.h@cloud.com>
@ashwin9390
Copy link
Contributor Author

Please delete the file from scripts/
-Done

@psafont psafont merged commit 9177d03 into xapi-project:feature/py3 Jul 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants