Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-49212: Update datamodel for non-CDN update #5764

Merged
merged 2 commits into from
Jul 16, 2024
Merged

CP-49212: Update datamodel for non-CDN update #5764

merged 2 commits into from
Jul 16, 2024

Conversation

BengangY
Copy link
Contributor

@BengangY BengangY commented Jul 2, 2024 •
edited
Loading

Add a field "origin" in "repository" to indicate the origin of the repository.
It's an enum type with 2 values: "remote" and "bundle".

@coveralls
Copy link

Coverage Status

coverage: 44.887%. remained the same
when pulling ac8fc26 on BengangY:private/bengangy/CP-49212
into 2008661 on xapi-project:feature/non-cdn-update.

@BengangY BengangY marked this pull request as ready for review July 2, 2024 02:12
minglumlu
minglumlu reviewed Jul 2, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
minglumlu
minglumlu reviewed Jul 2, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
minglumlu
minglumlu reviewed Jul 2, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
minglumlu
minglumlu reviewed Jul 2, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
gangj
gangj reviewed Jul 2, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@BengangY BengangY force-pushed the private/bengangy/CP-49212 branch 2 times, most recently from c5adf3e to 0aec86b Compare July 2, 2024 09:42
@coveralls
Copy link

Coverage Status

coverage: 44.887%. remained the same
when pulling 0aec86b on BengangY:private/bengangy/CP-49212
into 2008661 on xapi-project:feature/non-cdn-update.

@BengangY BengangY requested review from minglumlu and gangj July 2, 2024 09:48
@xapi-project xapi-project deleted a comment from coveralls Jul 2, 2024
lindig
lindig reviewed Jul 2, 2024
View reviewed changes
ocaml/xapi/xapi_globs.ml Outdated Show resolved Hide resolved
@BengangY BengangY requested a review from lindig July 3, 2024 06:29
@coveralls
Copy link

Coverage Status

coverage: 44.887%. remained the same
when pulling 3999dd8 on BengangY:private/bengangy/CP-49212
into 2008661 on xapi-project:feature/non-cdn-update.

minglumlu
minglumlu reviewed Jul 3, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 44.887%. remained the same
when pulling 9966eae on BengangY:private/bengangy/CP-49212
into 2008661 on xapi-project:feature/non-cdn-update.

@BengangY BengangY requested a review from minglumlu July 3, 2024 09:00
gangj
gangj reviewed Jul 4, 2024
View reviewed changes
ocaml/xapi/xapi_globs.ml Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 44.887%. remained the same
when pulling d1cd7d6 on BengangY:private/bengangy/CP-49212
into 2008661 on xapi-project:feature/non-cdn-update.

lindig
lindig reviewed Jul 11, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
ocaml/tests/test_repository.ml Outdated Show resolved Hide resolved
ocaml/tests/test_repository.ml Outdated Show resolved Hide resolved
robhoes
robhoes reviewed Jul 12, 2024
View reviewed changes
ocaml/xapi/repository.ml Outdated Show resolved Hide resolved
robhoes
robhoes approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@robhoes robhoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment about the datamodel lifecycle values, but otherwise this looks good.

@BengangY BengangY mentioned this pull request Jul 14, 2024
Merged
@BengangY BengangY force-pushed the private/bengangy/CP-49212 branch 3 times, most recently from aaf2851 to bfe61b7 Compare July 15, 2024 08:03
@BengangY
CP-49212: Update datamodel for non-CDN update
6220147 
Add a field "origin" in "repository" to indicate the origin of the
repository. It's an enum type with 2 values: "remote" and "bundle".

Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
@BengangY
CP-49212: Add UT for update datamodel for non-CDN update
4824a91 
Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
@minglumlu minglumlu merged commit 20136cd into xapi-project:feature/non-cdn-update Jul 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindig lindig lindig left review comments

@robhoes robhoes robhoes approved these changes

@gangj gangj gangj approved these changes

@minglumlu minglumlu minglumlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BengangY @coveralls @robhoes @lindig @minglumlu @gangj