CP-50100: backup-sr-metadata,restore-sr-metadata: 2to3, fix pytype, pyright

[ashwin9390]

Main ticket CP-49100 :Move python3 scripts from scripts directory to python3 directory.

Sub task CP-50100:

2to3 and warning fixes to prepare its to move to python3 dirrectory:

Commit 1:

• apply 2to3 -w and update shebang

Commit 2:

• pyright:

  • Add VDI to the XenAPI typing stub as we don't do type checking of VDI attributes yet.
  • move sys.exit() from inside usage() to after to make pyright aware of the exit.

• apply isort to sort the imports

• update the logout() handler to:

  • use contextlib.suppress()
  • move it into main() to fix the undeclared session warning.

• remove the unused variable vdis: vdis = session.xenapi.SR.get_all_records()

• remove trailing whitespace

Author : Signed-off-by: Bernhard Kaindl bernhard.kaindl@cloud.com

Committed by: Signed-off-by: Ashwinh ashwin.h@cloud.com

[bernhardkaindl]

@psafont: Please see the PR description on info about the fixes.

[psafont]

There are a few warnings remaining in scripts/restore-sr-metadata.py

[bernhardkaindl]

@psafont: Applied the minimal fixes for the pylint warnings from reviewdog:

This fixes the warnings show in by GitHub CI (using reviewdog):

• Removed unused imports of os and time
• Applied folding the too long line from the changes that black would make.

Any remaining formatting and pylint fixes can be applied later as well.