xapi-cli-server: add functions to print maps #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
It forced users to define how the elements were concatenated, allowing usage to be inconsistent. Fortunately this was not the case, but it's better to define the concatenation in a single place and reduce possible mistakes. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
It forced users to define how the elements were concatenated, allowing usage to be inconsistent. Fortunately this was not the case, but it's better to define the concatenation in a single place and reduce possible mistakes. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
robhoes
reviewed
Jul 13, 2024
| @@ -182,6 +182,10 @@ let map_and_concat_compat f rs = concat_with_comma (List.map f rs) | |||
|
|
|||
| let get_uuids_from_refs rs = map_and_concat get_uuid_from_ref rs | |||
|
|
|||
| let get_from_map rs = | |||
| let make_kv (a, b) = Printf.sprintf "%s: %s" a b in | |||
There was a problem hiding this comment.
Ah no, I see now that map_and_concat does the concat with semicolons.
robhoes
approved these changes
Jul 13, 2024
lindig
approved these changes
Jul 15, 2024
| raise (Api_errors.Server_error (List.hd params, List.tl params)) | ||
| match Client.Task.get_error_info ~rpc ~session_id ~self:task_id with | ||
| | [] -> | ||
| raise Api_errors.(Server_error (internal_error, [])) |
There was a problem hiding this comment.
I think it's worth defining a function internal_error for this related pattern. @last-genius recently defined one, maybe it's accessible from here or could be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, users were forced to define how the elements were concatenated, allowing usage to
be inconsistent.
Fortunately this was not the case, but it's better to define the concatenation
in a single place and reduce possible mistakes.