CA-395789: Add polling to cluster health state update #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jul 22, 2024
psafont
approved these changes
Jul 22, 2024
Vincent-lau
force-pushed
the
private/shul2/health-poll
branch
from
733afff
to
d9b18bd
Compare
gangj
reviewed
Aug 1, 2024
gangj
reviewed
Aug 1, 2024
gangj
reviewed
Aug 1, 2024
gangj
approved these changes
Aug 1, 2024
Vincent-lau
force-pushed
the
private/shul2/health-poll
branch
from
d9b18bd
to
14e2c71
Compare
It was observed that the corosync-notifyd might send a notification when the data shown in corosync-quorumtool has not been updated. This causes xapi-clusterd to return the out-of-date cluster information to xapi. Xapi will not have a chance of updating these states again until there is a further change in the cluster (which may not happen for a long time). Now add polling in xapi to update the cluster info every 5 minutes, making sure that in the worst case, we still get up-to-date information after a 5-minute delay. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
gangj
approved these changes
Aug 2, 2024
gangj
reviewed
Aug 2, 2024
lindig
approved these changes
Aug 2, 2024
Vincent-lau
force-pushed
the
private/shul2/health-poll
branch
2 times, most recently
from
0debc2c
to
58a1420
Compare
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that the corosync-notifyd might send a notification when the data shown in corosync-quorumtool has not been updated. This causes xapi-clusterd to return the out-of-date cluster information to xapi. Xapi will not have a chance of updating these states again until there is a further change in the cluster (which may not happen for a long time).
Now add polling in xapi to update the cluster info every 5 minutes, making sure that in the worst case, we still get up-to-date information after a 5-minute delay.