opam: dunify message-switch-unix's metadata #5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
edwintorok
approved these changes
Jul 23, 2024
Vincent-lau
approved these changes
Jul 23, 2024
| depends: [ | ||
| "ocaml" |
There was a problem hiding this comment.
no longer depends on OCaml?
There was a problem hiding this comment.
Unless we want to specify a version, the line is useless as ocaml will be installed because of dune
| ppx_deriving_rpc | ||
| rpclib | ||
| (xapi-stdext-threads (= :version)) | ||
| ) |
There was a problem hiding this comment.
nitpick: do we want to add a (tags (org:xapi-project)) here?
There was a problem hiding this comment.
If we want to keep the tag, it needs to be added to all packages individually, kind of a pain. Might be worth opening a ticket or even a PR to define per-project instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accompanies xapi-project/xs-opam#692
the dependency to xapi-stdext-threads was added recently: https://github.com/xapi-project/xen-api/pull/5861/files