CP-50181: Percent decode all Uri paths before using them #5877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uri.path
returns percent-encoded output, therefore it can't be expected to behave correctly in cases where it's used to map to Unix files. Our PR upstream introducedUri.path_unencoded
function, use that instead.There is one usage of
Uri.path
left:But this is not dangeous as it's used as an argument for Uri.make, which is fine without
pct_decode
:I'm not sure it's worth adding a quality gate to future-proof this.
===
xapi-project/xs-opam#693 is required to build and merge this, therefore currently opening as a draft - but it's ready for review.