CP-50426: Trace external authentication modules #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stylistic change is shorter than alternatives. The actual intention is to ensure that Merlin doesn't get confused when jumping to definition. The previous behaviour is that Merlin jumps to the type definition rather than realising it ought to jump to the implementation being referred to inside the record. This commit should be squashed together with what follows. Signed-off-by: Colin James <colin.barr@cloud.com>
Rewrites all functions in Auth_signature.t - the record type used by external authentication plugins - to take a xapi __context:Context.t as a first parameter. Changes are rather mechanical but, by threading this through, we can now add tracing to interesting parts (along with making the tracing more granular in future). Signed-off-by: Colin James <colin.barr@cloud.com>
Endows the propagated __context parameters with tracing (in some cases). It is not applied to all possible places as many of the functions are actually failure/no-op stubs. Signed-off-by: Colin James <colin.barr@cloud.com>
GabrielBuica
approved these changes
Jul 31, 2024
psafont
approved these changes
Jul 31, 2024
last-genius
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather mechanical change simply propagates a
__contextthrough each of the functions withinAuth_signature.tand selectively adds tracing to some of those functions (many of the functions are failure or no-op stubs).Below is a screenshot of a trace within Jaeger, which shows a failed login attempt using an Active Directory server:
I've committed 3 things but intend to squash them.