Add feature flags to block starting VMs #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag is added to the `enabled_when_unknown` list, which tells xapi to enable the feature if the flag is absent from `host.license_params` (as opposed to present and `true` or `false`). This is done to ensure that VM start is not inadvertently blocked during the rolling pool update that introduces this change. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
last-genius
reviewed
Aug 28, 2024
| @@ -26,7 +26,7 @@ let prototyped_of_field = function | |||
| | "Observer", "uuid" -> | |||
| Some "23.14.0" | |||
| | "Repository", "origin" -> | |||
| Some "24.21.0-next" | |||
| Some "24.23.0" | |||
There was a problem hiding this comment.
Given that xapi is already on 24.24.0, would this version not need incrementing? Or am I misunderstanding things here?
There was a problem hiding this comment.
Would agree - needs a rebase? @robhoes
There was a problem hiding this comment.
Those calls went into 24.23.0, didn't they? 24.24.0 only had a revert commit.
last-genius
approved these changes
Aug 28, 2024
psafont
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be released together with an update to v6d to enable the new flags by default.