Mirror api fix #6009
Mirror api fix #6009
Conversation
Defining as Copy of uri * uri results in JSON of `["Copy", ["uri", "uri"]]` but the unparse tries to enforce the `["uri", "uri"]` as a tuple, a type which is not supported by JSON. Signed-off-by: Mark Syms <mark.syms@cloud.com>
Signed-off-by: Mark Syms <mark.syms@cloud.com>
MarkSymsCtx
requested review from
robhoes,
edwintorok,
lindig,
psafont and
Vincent-lau
|
as discussed with @edwintorok it turns out that these bits were unusable from the generated python due to type confusion. As such it is highly unlikely that anyone has used them so a breaking change is in this case acceptable |
|
I am surprised that these changes don't require corresponding changes of existing client code. |
The client side of this is not wired up yet (@Vincent-lau ) will be working on wiring this up in xapi-storage-script. |
| operation from the [src] URI to the [dst] URI. *) | ||
| | CopyV1 of copy_operation_v1 | ||
| (** CopyV1 (key) represents an on-going copy operation | ||
| with the unique [key]. *) |
There was a problem hiding this comment.
what is this key representing?
There was a problem hiding this comment.
it's an abstract key that can be passed back to stat to obtain information about the running operation.
There was a problem hiding this comment.
so something like a handle/token
It was when we tried to wire up the Python side of this that we discovered that it couldn't actually be used as specified as the types in the ocaml can't be represented in JSON and so results from an operation can't be round-tripped and used as input for a subsequent API call. |
No description provided.