Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move qcheck to the proper place #680

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

edwintorok
Copy link
Contributor

XAPI (wsproxy) already depended on qcheck, but only uses qcheck-core. We now have a package that uses 'qcheck' (not qcheck-core), which passes on the external CI, but fails on the internal CI.

@GabrielBuica this is needed to fix a build failure in the internal CI.

XAPI (wsproxy) already depended on qcheck, but only uses qcheck-core.
We now have a package that uses 'qcheck' (not qcheck-core), which passes on the external CI,
but fails on the internal CI.

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@psafont
Copy link
Member

psafont commented Jun 12, 2024

#=== ERROR while compiling safe-resources.master ==============================#
# context              2.1.6 | linux/x86_64 | ocaml-base-compiler.4.14.1 | git+file:///home/runner/work/xs-opam/xs-opam
# path                 ~/work/xs-opam/xs-opam/_opam/.opam-switch/build/safe-resources.master
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p safe-resources -j 4
# exit-code            1
# env-file             ~/.opam/log/safe-resources-11815-c8fcea.env
# output-file          ~/.opam/log/safe-resources-11815-c8fcea.out
### output ###
# File "ocaml/libs/sexpr/test/dune", line 4, characters 12-17:
# 4 |  (libraries sexpr astring rresult qcheck alcotest threads))
#                 ^^^^^
# Error: Library "sexpr" not found.

the new test added needs to define a package @GabrielBuica

@psafont
Copy link
Member

psafont commented Jun 12, 2024

The error can be fixed by merging xapi-project/xen-api#5684

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@edwintorok edwintorok merged commit 7d5a680 into xapi-project:master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants